Skip to content

Update helm.mdx#18759

Closed
maksimnosal wants to merge 2 commits intohashicorp:mainfrom
maksimnosal:patch-1
Closed

Update helm.mdx#18759
maksimnosal wants to merge 2 commits intohashicorp:mainfrom
maksimnosal:patch-1

Conversation

@maksimnosal
Copy link

@maksimnosal maksimnosal commented Sep 12, 2023 •
edited
Loading

Added comments/requirements as per https://github.com/hashicorp/consul-dataplane/blob/7e075dc4310e609a31babe4cda5c24cfb0f6a416/cmd/consul-dataplane/main.go#L111

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@maksimnosal maksimnosal requested a review from a team as a code owner September 12, 2023 11:29
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 12, 2023
david-yu
david-yu reviewed Sep 14, 2023
View reviewed changes
david-yu
david-yu reviewed Oct 5, 2023
View reviewed changes
@david-yu
Copy link
Contributor

david-yu commented Oct 5, 2023

@maksimnosal Could you sign the CLA?

@david-yu david-yu added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.14 backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. labels Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Dec 4, 2023

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Dec 4, 2023
@maksimnosal maksimnosal requested a review from david-yu December 5, 2023 13:35
@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Dec 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 17, 2024

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Feb 17, 2024
@david-yu
Copy link
Contributor

david-yu commented Feb 20, 2024 •
edited
Loading

Closing as docs are updated here as comments instead: https://github.com/hashicorp/consul-k8s/blob/main/charts/consul/values.yaml

@david-yu david-yu closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-yu david-yu Awaiting requested review from david-yu

Assignees

No one assigned

Labels

backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. meta/stale Automatically flagged for inactivity by stalebot pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maksimnosal @hashicorp-cla @david-yu